feat: allow user to pass multiple files to `fix` and `check` commands by sinrohit-desco · Pull Request #119 · oppiliappan/statix

sinrohit-desco · 2025-08-13T07:15:50Z

Resolves #118

mightyiam · 2025-08-17T15:41:43Z

I think we should have this. How about a test though?

sinrohit-desco · 2025-08-18T06:03:38Z

I think we should have this. How about a test though?

Yeah, definitely but before that I want to rework the changes as the program needs to respect each .gitignore files.

TLATER

Yeah, I much prefer this, I overlooked the Walker when I looked at this.

I'll close #96

sinrohit-desco · 2025-08-19T12:27:12Z

I completely implemented the iterator using Walk from ignore crate. Let me know your thoughts @TLATER @mightyiam
If everything looks good to you guys, I will add tests.

TLATER

Looks really good, much better than the existing code! Error handling might need some work though.

To be clear, since apparently this is less common parlance than I thought, "nit" means a small thing that I don't really think needs to be addressed but point out anyway because I'm overly specific about programming. So feel free to ignore those comments if what they're talking about doesn't also annoy you.

TLATER · 2025-08-20T15:41:35Z


 use clap::Parser;
-use lib::{LINTS, session::Version};
+use lib::{session::Version, LINTS};


Nit: Spurious diff changes, it'd be best to revert that just for a clean commit history. Is this done by rustfmt? I didn't think import ordering is unstable?

Might as well squash the commits while you're at it.

This is happening because of pre-commit hook that runs when I try to commit.

Pre-commit hooks run locally, you could disable it. But fair enough, guess there's a pre-commit hook but it didn't exist when this file was originally written. It's a nit for a reason, solve or don't as you see fit; personally I'd probably put this in a separate commit, but I sometimes take commit hygiene too far.

Yeah, I will leave it up for the maintainer on how to proceed.

TLATER

LGTM, no further comments :) I'd love to resolve my earlier ones, sadly I don't have permissions to do that.

mightyiam · 2025-09-13T07:42:48Z

Sorry, I think #138 is the priority so we've been working on that.

mightyiam · 2025-10-14T05:06:33Z

Hey, #138 is complete. Sorry for the conflicts. Looking forward to reviewing this again.

sinrohit-desco · 2025-10-15T08:16:58Z

Hey, #138 is complete. Sorry for the conflicts. Looking forward to reviewing this again.

Hi Shahar! I have rebased the PR and resolved the conflicts.

mightyiam

Should this new feature include a test?

mightyiam · 2025-10-15T08:29:07Z

 };

-use crate::{LintMap, dirs, err::ConfigErr, utils};
+use crate::{dirs, err::ConfigErr, utils, LintMap};


Please do revert.

voruti · 2026-02-20T20:45:17Z

I was just testing this out, but it's not compiling correctly.

error: this argument is passed by value, but not consumed in the function body
  --> bin/src/dirs.rs:15:22
error: variables can be used directly in the `format!` string
  --> bin/src/dirs.rs:43:23
  --> bin/src/dirs.rs:60:17

sinrohit-desco · 2026-03-19T08:12:54Z

Apologies for leaving it unattended for this long.

I was just testing this out, but it's not compiling correctly.

error: this argument is passed by value, but not consumed in the function body
  --> bin/src/dirs.rs:15:22
error: variables can be used directly in the `format!` string
  --> bin/src/dirs.rs:43:23
  --> bin/src/dirs.rs:60:17

That's the clippy warning (error). I ran cargo build and didn't run clippy checks. Let me fix that and also rebase.

reimplement the iterator using ignore::Walk This implementation simplifies things a bit also it returns a lazy iterator which is memory efficient for large codebases.

mightyiam · 2026-03-19T09:14:10Z

Thank you for resuming. But, would you mind submitting against https://github.com/molybdenumsoftware/statix ?

sinrohit-desco · 2026-03-19T09:15:29Z

Thank you for resuming. But, would you mind submitting against https://github.com/molybdenumsoftware/statix ?

Sure thing!!

sinrohit-desco · 2026-03-20T07:17:27Z

Closing in favour of molybdenumsoftware#1921

Thank you for resuming. But, would you mind submitting against https://github.com/molybdenumsoftware/statix ?

sinrohit-desco marked this pull request as draft August 14, 2025 06:27

mightyiam mentioned this pull request Aug 18, 2025

Multiple file path arguments #69

Open

TLATER reviewed Aug 18, 2025

View reviewed changes

Comment thread bin/src/dirs.rs Outdated

sinrohit-desco force-pushed the patch-1 branch from a6a2b27 to 70a4c18 Compare August 19, 2025 12:23

sinrohit-desco requested a review from TLATER August 19, 2025 12:27

sinrohit-desco marked this pull request as ready for review August 19, 2025 12:29

TLATER reviewed Aug 20, 2025

View reviewed changes

sinrohit-desco force-pushed the patch-1 branch from 70a4c18 to 4c856de Compare September 10, 2025 09:05

sinrohit-desco requested a review from TLATER September 11, 2025 06:45

TLATER approved these changes Sep 11, 2025

View reviewed changes

sinrohit-desco force-pushed the patch-1 branch from 4c856de to 6e21d85 Compare October 15, 2025 08:15

mightyiam reviewed Dec 8, 2025

View reviewed changes

feat: allow user to pass multiple files to fix and check commands

c123c64

reimplement the iterator using ignore::Walk This implementation simplifies things a bit also it returns a lazy iterator which is memory efficient for large codebases.

sinrohit-desco force-pushed the patch-1 branch from 6e21d85 to c123c64 Compare March 19, 2026 08:34

sinrohit-desco closed this Mar 20, 2026

Conversation

sinrohit-desco commented Aug 13, 2025

Uh oh!

mightyiam commented Aug 17, 2025

Uh oh!

sinrohit-desco commented Aug 18, 2025

Uh oh!

TLATER left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sinrohit-desco commented Aug 19, 2025

Uh oh!

TLATER left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TLATER Aug 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sinrohit-desco Sep 10, 2025

Choose a reason for hiding this comment

Uh oh!

TLATER Sep 10, 2025

Choose a reason for hiding this comment

Uh oh!

sinrohit-desco Sep 11, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TLATER left a comment

Choose a reason for hiding this comment

Uh oh!

mightyiam commented Sep 13, 2025

Uh oh!

mightyiam commented Oct 14, 2025

Uh oh!

sinrohit-desco commented Oct 15, 2025

Uh oh!

mightyiam left a comment

Choose a reason for hiding this comment

Uh oh!

mightyiam Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

voruti commented Feb 20, 2026

Uh oh!

sinrohit-desco commented Mar 19, 2026

Uh oh!

mightyiam commented Mar 19, 2026

Uh oh!

sinrohit-desco commented Mar 19, 2026

Uh oh!

sinrohit-desco commented Mar 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

TLATER left a comment •

edited

Loading

TLATER Aug 20, 2025 •

edited

Loading